[clr-interp] Fix debugger issues in interpreter #123047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes debugger issues when working with interpreted code by ensuring that the EECodeInfo infrastructure can retrieve interpreter byte codes instead of interpreter stub addresses. The key addition is a new function GetInterpreterCodeFromInterpreterPrecodeIfPresent that unwraps interpreter precodes to get the actual bytecode addresses.
Key changes:
- New function
GetInterpreterCodeFromInterpreterPrecodeIfPresentto extract interpreter bytecode addresses from interpreter precodes - Helper method
GetCodeForInterpreterOrJittedin MethodDesc for easier access - Multiple DAC (Data Access Component) files updated to use the new function/helper when retrieving code addresses
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/vm/stubmgr.cpp | Adds null check for pPrecode to prevent dereferencing null pointers |
| src/coreclr/vm/precode.h | Declares new function GetInterpreterCodeFromInterpreterPrecodeIfPresent |
| src/coreclr/vm/precode.cpp | Implements GetInterpreterCodeFromInterpreterPrecodeIfPresent to unwrap interpreter precodes |
| src/coreclr/vm/method.hpp | Adds GetCodeForInterpreterOrJitted helper method for MethodDesc |
| src/coreclr/debug/daccess/request.cpp | Updates code address retrieval to use new helper/function in multiple locations |
| src/coreclr/debug/daccess/enummem.cpp | Uses GetCodeForInterpreterOrJitted for stack trace exception handling |
| src/coreclr/debug/daccess/dacdbiimpl.cpp | Updates GetMethodRegionInfo and GetNativeCodeInfoForAddr to use new function/helper |
| src/coreclr/debug/daccess/daccess.cpp | Updates multiple debugger functions to use GetCodeForInterpreterOrJitted and GetInterpreterCodeFromInterpreterPrecodeIfPresent |
Co-authored-by: Copilot <[email protected]>
jkotas
reviewed
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a set of issues found when attempting to use the debugger on interpreted code. In general we need to get the interpreter byte codes if possible when attempting to use the EECodeInfo infrastructure. These changes helped me debug issues that appeared in interpmode=2